Skip to content

chore(cicd): fix trigger for gh actions linting andctesting PR from fork #464

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 18, 2022

Conversation

flochaz
Copy link
Contributor

@flochaz flochaz commented Jan 14, 2022

Description of your changes

PRs from fork are not lint or tested properly with our current workflow. This PR change the trigger to make sure it runs on opened or synchronize (details below).

synchronize: Triggered when a pull request's head branch is updated. For example, when the head branch is updated from the base branch, when new commits are pushed to the head branch, or when the base branch is changed.
(cf. https://docs.github.com/en/developers/webhooks-and-events/webhooks/webhook-events-and-payloads#pull_request)

How to verify this change

check tests on this PR: https://github.com/devfest-bugbust/aws-lambda-powertools-typescript/pull/3 (don't look at the changes, what matters are the actions run).

PR status

Is this ready for review?: YES
Is it a breaking change?: NO

Checklist

  • My changes meet the tenets criteria
  • I have performed a self-review of my own code
  • I have commented my code where necessary, particularly in areas that should be flagged with a TODO, or hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • The code coverage hasn't decreased
  • I have added tests that prove my change is effective and works
  • New and existing unit tests pass locally and in Github Actions
  • Any dependent changes have been merged and published in downstream module
  • The PR title follows the conventional commit semantics

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@github-actions github-actions bot added the internal PRs that introduce changes in governance, tech debt and chores (linting setup, baseline, etc.) label Jan 14, 2022
@flochaz flochaz self-assigned this Jan 14, 2022
@flochaz flochaz requested a review from dreamorosi January 14, 2022 08:59
@dreamorosi dreamorosi added this to the production-ready-release milestone Jan 14, 2022
@dreamorosi dreamorosi requested a review from ijemmy January 14, 2022 12:44
@dreamorosi dreamorosi added the automation This item relates to automation label Jan 14, 2022
dreamorosi
dreamorosi previously approved these changes Jan 14, 2022
@flochaz flochaz merged commit cf6af25 into main Jan 18, 2022
@flochaz flochaz deleted the cicd/fixPR-gh-actions-trigger branch January 18, 2022 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automation This item relates to automation internal PRs that introduce changes in governance, tech debt and chores (linting setup, baseline, etc.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants